Re: Add support for specifying tables in pg_createsubscriber. - Mailing list pgsql-hackers

Hi Shubham,

Here are some v15 review comments.

======
IIUC the test cases #3 and #4 are supposed to reuse an existing publication.

There is logging in the code:
+ /* Reuse existing publication on publisher. */
+ pg_log_info("use existing publication \"%s\" in database \"%s\"",
+ dbinfo[i].pubname, dbinfo[i].dbname);

But I do not see those logs appearing anywhere in the test results.

I think this is caused by a simple mismatch in your test script
between the pub names in the db versus the pub names you are using in
those test commands.

======
Kind Regards,
Peter Smith.
Fujitsu Australia.