Re: Missing list_free in publicationcmds.c:OpenTableList - Mailing list pgsql-hackers

On Wed, Jul 29, 2026 at 2:35 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> shihao zhong <zhong950419@gmail.com> writes:
> > On Tue, Jul 28, 2026 at 11:44 PM shveta malik <shveta.malik@gmail.com> wrote:
> >> On Tue, Jul 28, 2026 at 10:30 AM Peter Smith <smithpb2250@gmail.com> wrote:
> >>> FWIW, I detected a missing `list_free`, which seems to have been
> >>> accidentally left out from commit 923def9.
>
> >> Okay since list_free for both relids and relids_with_rf are there, I
> >> think list_free for 'relids_with_rf' also make sense. So LGTM.
>
> AFAICS, that function is executed at most once per DDL command,
> in a command-lifetime memory context.  I think the right fix
> is not to add another list_free but to remove the misleadingly
> useless ones that are there.
>

I added list_free to be consistent with the existing logic.

Removing everything is also a consistent treatment for all lists. Done
as suggested in patch v2.

======
Kind Regards,
Peter Smith.
Fujitsu Australia