Re: Proposal: Conflict log history table for Logical Replication - Mailing list pgsql-hackers

A trivial review comment for v50-0003.

======
src/backend/replication/logical/conflict.c

1.
+void
+ProcessPendingConflictLogTuple(void)
+{
+ Relation conflictlogrel;
+ ConflictLogDest dest;
+
+ /* Nothing to do */
+ if (MyLogicalRepWorker->conflict_log_tuple == NULL)
+ return;
+
+ PG_TRY();
+ {

Those 2 variables are only used within the PG_TRY block, so they can
be declared there.

======
Kind Regards,
Peter Smith.
Fujitsu Australia