HI Vignesh,
Here are some minor review comments for patches 0001 and 0002.
////////////////////
Patch 0001
////////////////////
AlterSubscription:
1.1.
(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
- errmsg("ALTER SUBSCRIPTION ... REFRESH is not allowed for disabled
subscriptions")));
+ errmsg("ALTER SUBSCRIPTION ... REFRESH PUBLICATION is not allowed
for disabled subscriptions")));
Maybe this could use a parameter substitution like:
errmsg("%s is not allowed for disabled subscriptions", "ALTER
SUBSCRIPTION ... REFRESH PUBLICATION");
That way (in preparation for the next patch), there will be only 1
message requiring translation.
////////////////////
Patch 0002
////////////////////
Commit message:
2.1
"This command update the sequence entries present in the..."
/update/updates/
======
AlterSubscription:
2.2
+ if (!sub->enabled)
+ ereport(ERROR,
+ errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
+ errmsg("ALTER SUBSCRIPTION ... REFRESH SEQUENCES is not allowed for
disabled subscriptions"));
Can use the same message with parameter substitution as mentioned above (#1.1)
======
Kind Regards,
Peter Smith.
Fujitsu Australia
