Re: possible typo for CREATE PUBLICATION description - Mailing list pgsql-hackers

From Peter Smith
Subject Re: possible typo for CREATE PUBLICATION description
Date
Msg-id CAHut+Pu9bw9nWAB5c4M3WpF-h8z7bupO4ByAu=T_JHPELdG-7Q@mail.gmail.com
Whole thread Raw
In response to possible typo for CREATE PUBLICATION description  ("osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>)
List pgsql-hackers
On Thu, Oct 13, 2022 at 6:16 PM osumi.takamichi@fujitsu.com
<osumi.takamichi@fujitsu.com> wrote:
>
> Hi,
>
>
> I noticed a possible typo in the doc for create publication.
> This applies to PG15 as well.
> Kindly have a look at the attached patch for it.
>
>

Your typo correction LGTM.

FWIW, maybe other parts of that paragraph can be tidied too. e.g. The
words "actually" and "So" didn't seem needed IMO.

~

BEFORE
For an INSERT ... ON CONFLICT command, the publication will publish
the operation that actually results from the command. So depending on
the outcome, it may be published as either INSERT or UPDATE, or it may
not be published at all.

SUGGESTION
For an INSERT ... ON CONFLICT command, the publication will publish
the operation that results from the command. Depending on the outcome,
it may be published as either INSERT or UPDATE, or it may not be
published at all.

------
Kind Regards,
Peter Smith.
Fujitsu Australia



pgsql-hackers by date:

Previous
From: "osumi.takamichi@fujitsu.com"
Date:
Subject: possible typo for CREATE PUBLICATION description
Next
From: Nikita Malakhov
Date:
Subject: Re: Pluggable toaster