Re: [PATCH] Add pretty-printed XML output option - Mailing list pgsql-hackers

From Peter Smith
Subject Re: [PATCH] Add pretty-printed XML output option
Date
Msg-id CAHut+Pu7Mu1OtB2N_JYxX3Zb0XX5+1UsfpcZ9vPdhtJZkCp9Xg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add pretty-printed XML output option  (Jim Jones <jim.jones@uni-muenster.de>)
Responses Re: [PATCH] Add pretty-printed XML output option
List pgsql-hackers
On Thu, Feb 9, 2023 at 7:31 AM Jim Jones <jim.jones@uni-muenster.de> wrote:
>
> while working on another item of the TODO list I realized that I should
> be using a PG_TRY() block in he xmlDocDumpFormatMemory call.
>
> Fixed in v5.
>

I noticed the xmlFreeDoc(doc) within the PG_CATCH is guarded but the
other xmlFreeDoc(doc) is not. As the doc is assigned outside the
PG_TRY shouldn't those both be the same?

------
Kind Regards,
Peter Smith.
Fujitsu Australia.



pgsql-hackers by date:

Previous
From: Matthias van de Meent
Date:
Subject: Re: RFC: WAL infrastructure issues, updates and improvements
Next
From: Justin Pryzby
Date:
Subject: Re: Improve logging when using Huge Pages