Hi Nisha.
A couple of ad-hoc review comments for v4-0001...
======
src/bin/pg_dump/pg_dump.c
dumpPublicationNamespace:
1.
+ if (!first_except)
+ appendPQExpBufferStr(query, ")");
The logic seems ok, but the above seems a bit strange, checking
'first_except'. Maybe renaming to 'has_except' (and some small
refactoring) would read better?
~~~
2.
IIUC, the 'ALTER PUBLICATION' EXCEPT clause syntax change is not
introduced until your patch 0003. So, how does this dump code even
work when it relies on that ALTER PUBLICATION?
Furthermore, the patch 0003 commit message says 'ALTER PUBLICATION pub
SET TABLES', but this dump code is using 'ALTER PUBLICATION pub ADD
TABLES' (note ADD v SET). Something seems suspicious...
======
Kind Regards,
Peter Smith.
Fujitsu Australia
