Re: Redundant/mis-use of _(x) gettext macro? - Mailing list pgsql-hackers

On Fri, Apr 24, 2026 at 10:14 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2026-Apr-24, Peter Smith wrote:
>
> > OK. Including the comma within a larger translated string seems like a
> > better idea.
> >
> > Since you now have the list `length`, I wondered why not simplify
> > further to use list_nth indexing? Then you can remove
> > `foreach_current_index` and `lc`.
>
> WFM.
>
> > Also, why did you choose to implement `last` versus `first` logic?
> > e.g. How about this?
>
> >         {
> >             if (first)
> >                 appendStringInfo(dest, _("\"%s\""), pubname);
> >             else
> >                 appendStringInfo(dest, _(", \"%s\""), pubname);
> >         }
>
> I don't know, it just seemed more natural.  The whole ", foo" style
> simply feels weird to me.  It seems a matter of choice only though, so
> if you feel strongly about this, I'm not opposed.
>

Personally, I prefer `first` logic because
a) The length of the list is not required up-front
b) At each iteration, the built string makes sense instead of always
having a dangling ',' until the final iteration

But it is not a big deal. This thread is about the translation part,
so whatever way makes the most sense for translators is fine with me.

======
Kind Regards,
Peter Smith
Fujitsu Australia