Re: create subscription - improved warning message - Mailing list pgsql-hackers

From Peter Smith
Subject Re: create subscription - improved warning message
Date
Msg-id CAHut+PtRuLMd8emz1N3ZTnQcciD-ru=p+mq-mPzfD2C1fHYVzw@mail.gmail.com
Whole thread Raw
In response to RE: create subscription - improved warning message  ("shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>)
Responses Re: create subscription - improved warning message  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Wed, Oct 19, 2022 at 2:44 PM shiy.fnst@fujitsu.com
<shiy.fnst@fujitsu.com> wrote:
>
...

>
> +test_sub=# CREATE SUBSCRIPTION sub1
> +test_sub-# CONNECTION 'host=localhost dbname=test_pub'
> +test_sub-# PUBLICATION pub1
> +test_sub-# WITH (slot_name=NONE, enabled=false, create_slot=false);
> +WARNING:  subscription was created, but is not connected
> +HINT:  To initiate replication, you must manually create the replication slot, enable the subscription, and refresh
thesubscription.
 
> +CREATE SUBSCRIPTION
>
> In example 3, there is actually no such warning message when creating
> subscription because "connect=false" is not specified.
>

Oh, thanks for finding and reporting that. Sorry for my cut/paste
errors. Fixed in v7. PSA,

> I have tested the examples in the patch and didn't see any problem other than
> the one above.
>

Thanks for your testing.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment

pgsql-hackers by date:

Previous
From: Yugo NAGATA
Date:
Subject: Re: make_ctags: use -I option to ignore pg_node_attr macro
Next
From: Bharath Rupireddy
Date:
Subject: Re: thinko in basic_archive.c