Postgres Pro
Downloads
Home   >   mailing lists

Re: Handle infinite recursion in logical replication setup - Mailing list pgsql-hackers

From Peter Smith
Subject Re: Handle infinite recursion in logical replication setup
Date
Msg-id CAHut+PtPmLQfnO8j5YahiDrf6Lj04H3d=ncYxVuxBp2A=FDLWA@mail.gmail.com
Whole thread Raw
In response to Re: Handle infinite recursion in logical replication setup  (vignesh C <vignesh21@gmail.com>)
Responses Re: Handle infinite recursion in logical replication setup  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
Tree view 
Please find below my review comments for patch v17-0001:

======

1. Commit message
Add a missing test to verify only-local option in test_decoding plugin.

"option" -> "parameter"

======

2. contrib/test_decoding/sql/replorigin.sql

2a.
+-- Verify that remote origin data is not returned with only-local option

SUGGESTION
-- Verify the behaviour of the only-local parameter

2b.
+-- Remote origin data returned when only-local option is not set

"option" -> "parameter"

2c.
+-- Remote origin data not returned when only-local option is set

"option" -> "parameter"

------
Kind Regards,
Peter Smith.
Fujitsu Australia

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: some aspects of our qsort might not be ideal
Next
From: Peter Smith
Date:
Subject: Re: Handle infinite recursion in logical replication setup