Re: Add common function ReplicationOriginName. - Mailing list pgsql-hackers

From Peter Smith
Subject Re: Add common function ReplicationOriginName.
Date
Msg-id CAHut+Pswa-x9T=0xHScm0TTB_h1sHNMyeYn80_5T5V5SPqXVvA@mail.gmail.com
Whole thread Raw
In response to Re: Add common function ReplicationOriginName.  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
On Tue, Sep 20, 2022 at 6:36 PM Aleksander Alekseev
<aleksander@timescale.com> wrote:
>
> Hi Amit,
>
> > I think it is better to use Size. Even though, it may not fail now as
> > the size of names for origin will always be much lesser but it is
> > better if we are consistent. If we agree with this, then as a first
> > patch, we can make it to use Size in existing places and then
> > introduce this new function.
>
> OK, here is the updated patchset.
>
> * 0001 replaces int's with Size's in the existing code
> * 0002 applies Peter's patch on top of 0001
>

LGTM. Thanks!

-----
Kind Regards,
Peter Smith.
Fujitsu Australia



pgsql-hackers by date:

Previous
From: Himanshu Upadhyaya
Date:
Subject: Re: HOT chain validation in verify_heapam()
Next
From: Justin Pryzby
Date:
Subject: Re: Add 64-bit XIDs into PostgreSQL 15