Re: Distinguish publication exclusions in object addresses - Mailing list pgsql-hackers

From Peter Smith
Subject Re: Distinguish publication exclusions in object addresses
Date
Msg-id CAHut+PssUw0X0eiN3nEHXy40SKx3vL02Z8Orev-Pcz=fyPpHBw@mail.gmail.com
Whole thread
In response to Re: Distinguish publication exclusions in object addresses  (vignesh C <vignesh21@gmail.com>)
Responses Re: Distinguish publication exclusions in object addresses
Re: Distinguish publication exclusions in object addresses
List pgsql-hackers
AFAICT, the patch has traded one kind of quoting problem for another.

Before patch v3, the message might show nested quotes.

After patch v3, the message might show mismatched quotes:
CREATE PUBLICATION testpub9 FOR ALL TABLES EXCEPT (TABLE "schema has
embedded "" quotes"."part has embedded "" quotes");
ERROR:  cannot specify relation "schema has embedded " quotes.part has
embedded " quotes" in the publication EXCEPT clause

~

PSA a v3 top-up patch to address the new problem.

Of course, putting my escape_embedded_quotes() function where I did in
the top-up doesn't seem appropriate. It would be better to associate
that with the original RelationGetQualifiedRelationName() and call it
from there, but RelationGetQualifiedRelationName was removed, so...

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment

pgsql-hackers by date:

Previous
From: Bingshuai Li
Date:
Subject: Re: Bug in logical decoding with DDL and subtransactions
Next
From: 王红岩
Date:
Subject: Re: [PATCH v2] Optimize 64-bit atomic access on RV64