Re: tablesync copy ignores publication actions - Mailing list pgsql-hackers

From Peter Smith
Subject Re: tablesync copy ignores publication actions
Date
Msg-id CAHut+Psp+S-jdxz_5bqyUzLaVwrQwWfg=Yc7OODczerLF3cRgQ@mail.gmail.com
Whole thread Raw
In response to RE: tablesync copy ignores publication actions  ("shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>)
Responses Re: tablesync copy ignores publication actions
List pgsql-hackers
On Wed, Jun 15, 2022 at 5:05 PM shiy.fnst@fujitsu.com
<shiy.fnst@fujitsu.com> wrote:
>
...
> Thanks for updating the patch. Two comments:
>
> 1.
> +     it means the copied table <literal>t3</literal> contains all rows even when
> +     they do not patch the row filter of publication <literal>pub3b</literal>.
>
> Typo. I think "they do not patch the row filter" should be "they do not match
> the row filter", right?
>
> 2.
> @@ -500,7 +704,6 @@
>        </para>
>       </listitem>
>      </itemizedlist></para>
> -
>    </sect2>
>
>    <sect2 id="logical-replication-row-filter-examples">
>
> It seems we should remove this change.
>

Thank you for your review comments. Those reported mistakes are fixed
in the attached patch v3.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment

pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Modest proposal to extend TableAM API for controlling cluster commands
Next
From: Peter Smith
Date:
Subject: Re: