Re: src/bin/pg_upgrade/t/004_subscription.pl test comment fix - Mailing list pgsql-hackers

From Peter Smith
Subject Re: src/bin/pg_upgrade/t/004_subscription.pl test comment fix
Date
Msg-id CAHut+PsiW15N6nsC4D5Ey7R9g84-R2eR=hj7+sHz8d6fJA1Fkg@mail.gmail.com
Whole thread Raw
In response to Re: src/bin/pg_upgrade/t/004_subscription.pl test comment fix  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
On Wed, Jan 31, 2024 at 4:51 PM vignesh C <vignesh21@gmail.com> wrote:
>
> On Wed, 31 Jan 2024 at 10:27, Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > Hi,
> >
> > PSA a small fix for a misleading comment found in the pg_upgrade test code.
>
> Is the double # intentional here, as I did not see this style of
> commenting used elsewhere:
> +# # Upgraded regress_sub1 should still have enabled and failover as true.
> +# # Upgraded regress_sub2 should still have enabled and failover as false.
>

Unintentional caused by copy/paste. Thanks for reporting. I will post
a fixed patch tomorrow.

======
Kind Regards,
Peter Smith.
Fujitsu Australia



pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Documentation to upgrade logical replication cluster
Next
From: Richard Guo
Date:
Subject: Re: Oversight in reparameterize_path_by_child leading to executor crash