Re: Logical Replication of sequences - Mailing list pgsql-hackers

From Peter Smith
Subject Re: Logical Replication of sequences
Date
Msg-id CAHut+PsgZkEegDzhJ2=DwDkrks6g6aQ6LX1-M+XBBt4PP-MX3g@mail.gmail.com
Whole thread Raw
In response to Re: Logical Replication of sequences  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
Hi Vignesh,

Here are some review comments for patch v20250325-0001.

======
src/test/regress/expected/sequence.out

1.
+SELECT last_value, log_cnt, is_called  FROM
pg_sequence_state('sequence_test');
+ last_value | log_cnt | is_called
+------------+---------+-----------
+         99 |      32 | t
+(1 row)
+

I think 32 may seem like a surprising value to anybody reading these
results. Perhaps it will help if there can be a comment for this .sql
test to explain why this is the expected value.

======
Kind Regards,
Peter Smith.
Fujitsu Australia



pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Re: Silence resource leaks alerts
Next
From: Ranier Vilela
Date:
Subject: Fix a resource leak (src/backend/utils/adt/rowtypes.c)