Re: Include sequences in publications created by pg_createsubscriber - Mailing list pgsql-hackers

From Peter Smith
Subject Re: Include sequences in publications created by pg_createsubscriber
Date
Msg-id CAHut+PsTUJLhPyUq84KfEnMwjmFz0813_LAOk57F+TFmBqwF6g@mail.gmail.com
Whole thread
In response to Re: Include sequences in publications created by pg_createsubscriber  (Ashutosh Sharma <ashu.coek88@gmail.com>)
List pgsql-hackers
On Thu, Jun 25, 2026 at 5:35 PM Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
>
> Hi,
>
> On Thu, Jun 25, 2026 at 6:29 AM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > 3.
> >       <para>
> >        Enable the subscription for each specified database on the target server.
> >        The subscription starts applying transactions from the replication start
> > -      point.
> > +      point. The subscription is configured to include sequences.
> >       </para>
> >
> > This implies there was some special subscription "configuration" for
> > getting sequences, but it just gets sequences because sequences were
> > published. Maybe you don't need to say anything here. Or, maybe reword
> > to just say "The subscription will include sequences".
> >
>
> What if the subscription uses an existing publication that doesn't
> include sequences? In that case, would it be correct to say that the
> subscription will include sequences?
>

Oops. Fair point. Looks like the original patch text suffered similar issues.

A more descriptive explanation seems needed for this to talk about the
differences of internal publications versus user-supplied ones....
e.g. a user-publication may even be only FOR ALL SEQUENCES and not
even have tables in them... then what?

======
Kind Regards,
Peter Smith.
Fujitsu Australia.



pgsql-hackers by date:

Previous
From: "cca5507"
Date:
Subject: Re: Handle concurrent drop when doing whole database vacuum
Next
From: Chao Li
Date:
Subject: Re: doc: fix pg_stat_autovacuum_scores threshold wording