Re: DOCS - ALTER PUBLICATION - description has confusing slash-list - Mailing list pgsql-hackers

From Peter Smith
Subject Re: DOCS - ALTER PUBLICATION - description has confusing slash-list
Date
Msg-id CAHut+PsAbLe=fz1RxOdHr9FWrWatoCBEWCFMefqTmCD1NryWmg@mail.gmail.com
Whole thread
In response to DOCS - ALTER PUBLICATION - description has confusing slash-list  (Peter Smith <smithpb2250@gmail.com>)
List pgsql-hackers
On Tue, Aug 11, 2026 at 1:20 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Aug 5, 2026 at 2:06 PM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > I  noticed that the Description section of the ALTER PUBLICATION page
> > [1] has a poorly worded sentence:
> >
> > "Note that adding tables/except tables/schemas to a publication that
> > is already subscribed to will require an ALTER SUBSCRIPTION ...
> > REFRESH PUBLICATION action"
> >
> > The problem is due to that strange slash-list. Apart from being
> > difficult to read, it makes it sound as if there's a distinct object
> > called an "except table", when what's meant is "changing a
> > publication's EXCEPT list."
> >
> > PSA patch v1 to reword this using plain English.
> >
>
> LGTM. minot nitpic: "...publication.  Note", here instead of two
> spaces, let's use one space to be consistent with the nearby doc
> wording. Also, this needs to be backpatched to 19, see if applied and
> build cleanly on 19 as well.
>

Thanks for checking the patch. I've modified it as suggested, to
remove the extra space.

I also confirmed that it applies/builds cleanly on PG_REL19_STABLE.

~

PSA patch v2.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment

pgsql-hackers by date:

Previous
From: Peipei YIN
Date:
Subject: [PATCH] Refactor remaining zero-fill relation extensions to use smgrzeroextend()
Next
From: Bharath Rupireddy
Date:
Subject: Re: [PATCH] Release replication slot on error in SQL-callable slot functions