[Patch] Omit virtual generated columns from test_decoding output - Mailing list pgsql-hackers

From SATYANARAYANA NARLAPURAM
Subject [Patch] Omit virtual generated columns from test_decoding output
Date
Msg-id CAHg+QDfTh3UbB-Ed--o2Bd=SBDJoEiG-qp3C0+ETDibF63y=dw@mail.gmail.com
Whole thread
Responses Re: [Patch] Omit virtual generated columns from test_decoding output
List pgsql-hackers
Hi Hackers,

Virtual generated columns are not stored on disk, so heap_getattr() in
tuple_to_stringinfo() always returned NULL for them, producing
misleading output such as

  table public.t: INSERT: a[integer]:1 b[integer]:10 c[integer]:null

even though the user could observe a non-null value via SELECT.  Stored
generated columns continue to be emitted as before because their values
do live in the heap tuple.

This matches the pgoutput's logicalrep_should_publish_column()
which never publishes virtual generated columns. Added a regression test.
Please find the patch attached.

Thanks,
Satya
Attachment

pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: Row pattern recognition
Next
From: Richard Guo
Date:
Subject: Re: Wrong results from inner-unique joins caused by collation mismatch