Request a Demo
Home   >   mailing lists

Re: [Bug]Vacuum full silently NULL out fast default columns - Mailing list pgsql-hackers

From SATYANARAYANA NARLAPURAM
Subject Re: [Bug]Vacuum full silently NULL out fast default columns
Date
Msg-id CAHg+QDegHnVEFdmp8e_k6b4DhC4R0MpCv26SEhz6gYSeZt-nVw@mail.gmail.com
Whole thread
In response to Re: [Bug]Vacuum full silently NULL out fast default columns  (Álvaro Herrera <alvherre@kurilemu.de>)
Responses Re: [Bug]Vacuum full silently NULL out fast default columns
List pgsql-hackers
Tree view
Hi,

On Mon, May 4, 2026 at 10:41 AM Álvaro Herrera <alvherre@kurilemu.de> wrote:
On 2026-May-04, SATYANARAYANA NARLAPURAM wrote:

> On Mon, May 4, 2026 at 6:40 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:

> > A quick bisect run agrees that it broke here:
> >
> > 28d534e2ae0ac888b5460f977a10cd9bb017ef98 is the first bad commit
> > commit 28d534e2ae0ac888b5460f977a10cd9bb017ef98 (HEAD)
> > Author: Álvaro Herrera <alvherre@kurilemu.de>
> > Date:   Mon Apr 6 21:55:08 2026 +0200
> >
> >     Add CONCURRENTLY option to REPACK

Right.

> Thanks for reviewing! Attached v2 patch. Agreed, tried to optimize LOC in
> V1. Before the change loop was not breaking early, I fixed that as
> well in V2.

Yeah, this seems a good approach to me.  I propose some more comment
updates though, and I also thought it'd be a good idea to add a test for
REPACK CONCURRENTLY while at it.

This patch LGTM. It applied cleanly and all the tests passed.

Thanks,
Satya 

pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: off-by-one in pg_repack index loop
Next
From: David Geier
Date:
Subject: Re: Avoid calling SetMatViewPopulatedState if possible