> > Hi! Your v2 looks fine > > The only question for me is, should we add any regression test to exercise this code, or it is not worth the troubles? > > I've checked contents of out regression tests. I see we very rarely > include SQLSTATE there, mostly in psql and plpgsql tests. Thus, I > think we should just fix the SQLSTATE without dedicating a test for > that. So, I'm going to push the patch from Tender Wang if no > objections.
Ok, no objections.
I added this to [1] commitfest in case we forgot this little issue.