Re: Standby accepts recovery_target_timeline setting? - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Standby accepts recovery_target_timeline setting?
Date
Msg-id CAHGQGwHpgbn3rOS0MmbLXTUiSE44z9hM-2S9WHvHwjnAP_BX9w@mail.gmail.com
Whole thread Raw
In response to Re: Standby accepts recovery_target_timeline setting?  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: Standby accepts recovery_target_timeline setting?
List pgsql-hackers
On Mon, Sep 30, 2019 at 6:59 AM Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
>
> On 2019-09-29 18:36, Fujii Masao wrote:
> > Yes, but ArchiveRecoveryRequested should be checked instead of
> > InArchiveRecovery, I think. Otherwise recovery targets would take effect
> > when recovery.signal is missing but backup_label exists. In this case,
> > InArchiveRecovery is set to true though ArchiveRecoveryRequested is
> > false because recovery.signal is missing.
> >
> > With the attached patch, I checked that the steps that I described
> > upthread didn't reproduce the issue.
>
> Your patch looks correct to me.

Thanks! So I committed the patch.

Also we need to do the same thing for other recovery options like
restore_command. Attached is the patch which makes crash recovery
ignore restore_command and recovery_end_command.

Regards,

-- 
Fujii Masao

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Hooks for session start and end, take two
Next
From: Amit Langote
Date:
Subject: Re: default partitions can be partitioned and have default partitions?