On Tue, Jul 14, 2026 at 4:05 AM surya poondla <suryapoondla4@gmail.com> wrote:
>
> Hi Fujii,
>
> The current wording in the docs is misleading. +1 to the patch for correcting it.
> log_parameter_max_length only affects the "Parameters: ..." line that appears alongside logged statements in the
serverlog.
> That line is never emitted when only log_duration is turned on. It only shows up when log_min_duration_statement (or
asample-rate variant) is what causes the statement to be logged.
> So the change looks accurate.
Thanks for the review!
> 1. log_min_duration_sample and log_transaction_sample_rate also cause "Parameters:" lines to be emitted, and are
therefore
> also affected by log_parameter_max_length. "and related settings" arguably covers them, but if we want the
enumerationto be more
> precise than before, would it be worth naming them explicitly? Either way is fine just curious about the rationale.
TBH I'm also fine with either approach.
> 2. This wording was introduced in 0b34e7d307e and is in every supported branch. Should this be back patched?
Yes, I think this should be backpatched to all supported versions.
Regards,
--
Fujii Masao