Re: gaussian distribution pgbench - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: gaussian distribution pgbench
Date
Msg-id CAHGQGwHXwqoYp3GnABbm_yXsnRFTsAYHA2RMd278xF72wx3C_Q@mail.gmail.com
Whole thread Raw
In response to Re: gaussian distribution pgbench  (KONDO Mitsumasa <kondo.mitsumasa@lab.ntt.co.jp>)
Responses Re: gaussian distribution pgbench
Re: gaussian distribution pgbench
List pgsql-hackers
On Tue, Mar 11, 2014 at 1:49 PM, KONDO Mitsumasa
<kondo.mitsumasa@lab.ntt.co.jp> wrote:
> (2014/03/09 1:49), Fabien COELHO wrote:
>>
>>
>> Hello Mitsumasa-san,
>>
>>> New "\setrandom" interface is here.
>>>  \setrandom var min max [gaussian threshold | exponential threshold]
>>
>>
>>> Attached patch realizes this interface, but it has little bit ugly
>>> codeing in
>>> executeStatement() and process_commands()..
>>
>>
>> I think it is not too bad. The "ignore extra arguments on the line" is a
>> little
>> pre-existing mess anyway.
>
> All right.
>
>
>>> What do you think?
>>
>>
>> I'm okay with this UI and its implementation.
>
> OK.

We should do the same discussion for the UI of command-line option?
The patch adds two options --gaussian and --exponential, but this UI
seems to be a bit inconsistent with the UI for \setrandom. Instead,
we can use something like --distribution=[uniform | gaussian | exponential].

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: [PATCH] Store Extension Options
Next
From: Robert Haas
Date:
Subject: Re: [PATCH] Store Extension Options