Request a Demo
Home   >   mailing lists

Re: [PATCH] pg_walsummary: suppress limit output with --quiet - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: [PATCH] pg_walsummary: suppress limit output with --quiet
Date
Msg-id CAHGQGwHVmk+M7mAQ8ybKKgkX=QPg-oz=6CvFGUGwmtVzrbYuYQ@mail.gmail.com
Whole thread
In response to [PATCH] pg_walsummary: suppress limit output with --quiet  ("Koshi Shibagaki (Fujitsu)" <shibagaki.koshi@fujitsu.com>)
List pgsql-hackers
Tree view 
On Mon, Oct 5, 2026 at 12:23 PM Koshi Shibagaki (Fujitsu)
<shibagaki.koshi@fujitsu.com> wrote:
> Feedback would be appreciated.

Thanks for the patch!

+for my $option ('-q', '--quiet')

Testing both forms with the same input and expected output seems a bit
overkill for this fix, since both set the same flag. Isn't testing just
one of them be sufficient?

+# Quiet mode must still parse every file, including the final checksum.

Isn't this primarily adding test coverage for existing quiet-mode behavior,
rather than testing the bug being fixed? If so, it might be better to leave
this out of the bug-fix patch intended for backpatching. Thought?

Also, this fix should be backpatched to v17, where pg_walsummary was
introduced?

Regards,


--
Fujii Masao

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: [PATCH] Add memory/disk usage for Function Scan nodes in EXPLAIN
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: [PATCH] pg_walsummary: suppress limit output with --quiet