Re: file_fdw: Support multi-line HEADER option. - Mailing list pgsql-hackers

On Wed, Jan 21, 2026 at 5:18 PM Steven Niu <niushiji@gmail.com> wrote:
> I've noticed an inconsistent naming convention in the patch:
> we use a capitalized Boolean for the boolean type, but a lowercase integer when referring to the value type.
>
> + errmsg("%s requires a Boolean value, an integer "
> +               "value greater than or equal to zero
>
> Is there any reason why we follow this mixed style?

I don't have a strong opinion on this. "Boolean value" has been used in command
error messages from before, and I couldn't find any messages that use the term
"Integer". So I committed the patch with the original wording. If this turns out
to be an issue, we can revisit it later.


> Another nitpick in v6-0001 patch:
> tow whitespaces are between "special" and "value"
> +                second %s is the special  value "match" for that option */

Thanks for catching that! I've fixed it.

I've pushed the patches. Thanks!

Regards,

--
Fujii Masao