Re: reaper should restart archiver even on standby - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: reaper should restart archiver even on standby
Date
Msg-id CAHGQGwHS3KNxt4iU+cKx-5j2zerAi6+C-ORjVuyBd8aS-j50Eg@mail.gmail.com
Whole thread Raw
In response to Re: reaper should restart archiver even on standby  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Thu, Jun 11, 2015 at 1:39 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> Fujii Masao wrote:
>
>> Agreed. The attached patch defines the macro to check whether archiver is
>> allowed to start up or not, and uses it everywhere except sigusr1_handler.
>> I made sigusr1_handler use a different condition because only it tries to
>> start archiver in PM_STARTUP postmaster state and it looks a bit messy
>> to add the check of that state into the centralized check condition.
>
> WFM, but do these macros in xlog.h need a one-line comment to state
> their purpose?

Yes, I added the comments and just pushed the patch. Thanks!

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Reconsidering the behavior of ALTER COLUMN TYPE
Next
From: Andrew Dunstan
Date:
Subject: Re: git push hook to check for outdated timestamps