Re: [PATCH] psql: Add missing IO option to EXPLAIN tab completion - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: [PATCH] psql: Add missing IO option to EXPLAIN tab completion
Date
Msg-id CAHGQGwHPA_Zc0=-p8Fc=n1HXwf0UABp=XWCyq9r3vPca7ajDGQ@mail.gmail.com
Whole thread
List pgsql-hackers
On Wed, May 13, 2026 at 2:49 PM Zhenwei Shang <a934172442@gmail.com> wrote:
>
>
>
> Afrah Razzak <mypg.afrah@gmail.com> 于2026年5月13日周三 11:35写道:
>>
>> Hi,
>>
>> Commit 681daed9316 added EXPLAIN (IO) as a new boolean option, but
>> psql's tab completion was not updated to include it.
>>
>> Currently:
>>
>>     EXPLAIN (<Tab>      -- IO is not listed
>>   EXPLAIN (IO <Tab>   -- no ON/OFF offered
>>
>> The attached patch adds IO to both the option keyword list and the
>> boolean ON/OFF completion pattern in tab-complete.in.c.
>>
>> Thanks,
>> Afrah Razzak
>>
> Looks correct to me. EXPLAIN (IO) is a boolean option, so adding it to both the option keyword list and the ON/OFF
completionbranch is the right fix. 

I've pushed the patch. Thanks!

Regards,

--
Fujii Masao



pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Set notice receiver before libpq connection startup
Next
From: Chengpeng Yan
Date:
Subject: Re: [PATCH] Fix overflow and underflow in regr_r2()