Re: pg_test_timing: fix unit typo and widen diff type - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: pg_test_timing: fix unit typo and widen diff type
Date
Msg-id CAHGQGwHFHghHRn1427m_ZH_D9t0gytKRa96Uid-pJ4VyZCvyOw@mail.gmail.com
Whole thread
In response to Re: pg_test_timing: fix unit typo and widen diff type  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: pg_test_timing: fix unit typo and widen diff type
List pgsql-hackers
On Wed, Apr 22, 2026 at 5:58 PM Chao Li <li.evan.chao@gmail.com> wrote:
> PFA v4:
>
> * 0001 unchanged from v3.
> * 0002 changed size of histogram[] 64.

Thanks for updating the patch!

Since patch 0001 is a bug fix, it should be backpatched to the supported stable
branches. However, in v19 the unit should be changed like s/ms/ns, while in v18
and earlier s/ms/us, since those older branches report the diff in microseconds.
Right?

Patch 0002 looks more like an improvement than a bug fix, so we should probably
wait for the next CommitFest before committing it. Thoughts?

Regards,


--
Fujii Masao



pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: StringInfo fixes, v19 edition. Plus a few oddities
Next
From: Bertrand Drouvot
Date:
Subject: Fix DROP PROPERTY GRAPH "unsupported object class" error