Re: file_fdw: Support multi-line HEADER option. - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: file_fdw: Support multi-line HEADER option.
Date
Msg-id CAHGQGwH3PJ8an=Z-70s3Nv=YY3btAJ=qD76Tivh2XgnABq8Xmg@mail.gmail.com
Whole thread Raw
In response to Re: file_fdw: Support multi-line HEADER option.  (Álvaro Herrera <alvherre@kurilemu.de>)
Responses Re: file_fdw: Support multi-line HEADER option.
List pgsql-hackers
On Wed, Jan 21, 2026 at 12:07 AM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2026-Jan-20, Fujii Masao wrote:
>
> > I'm thinking to commit the attached patches.
>
> In 0001 I would recommend to move the string "match" to outside the
> message.  Otherwise a translator might be tempted to translate it, and
> then it would make no sense.  (I have never seen this happen in
> Postgres, but I have seen this kind of translation mistake in other
> software, and it is infuriating.)

Thanks for the review!

Agreed. I've updated the patches as suggested.
The revised versions are attached.

Regards,

--
Fujii Masao

Attachment

pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row
Next
From: Ilia Evdokimov
Date:
Subject: Re: Optional skipping of unchanged relations during ANALYZE?