Request a Demo
Home   >   mailing lists

Re: recovery.signal not cleaned up when both signal files are present - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: recovery.signal not cleaned up when both signal files are present
Date
Msg-id CAHGQGwH+2=VBsybF84TJLz3fyyKLkuXQD4=icwgd1Gb-a6O-Fw@mail.gmail.com
Whole thread
In response to Re: recovery.signal not cleaned up when both signal files are present  (Michael Paquier <michael@paquier.xyz>)
Responses Re: recovery.signal not cleaned up when both signal files are present
List pgsql-hackers
Tree view 
On Fri, Feb 13, 2026 at 3:18 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Feb 13, 2026 at 03:05:45PM +0900, Fujii Masao wrote:
> > Yeah, so I've added the test as suggested. The updated patch is attached.
>
>
> What's the point in having the check for the files in data_dir?  The
> second one for standby2 should be enough as this is to test only
> readRecoverySignalFile().

I added that test to verify that both files are removed even in the normal
standby case (i.e., when only standby.signal is present). However, if testing
only the case where both signal files are present is sufficient, I'm fine with
removing the data_dir check. Attached is an updated patch that checks only
the latter case for standby2.

I will commit this patch.

Regards,

--
Fujii Masao
Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Add a greedy join search algorithm to handle large join problems
Next
From: Viktor Holmberg
Date:
Subject: Re: Allow ON CONFLICT DO UPDATE to return EXCLUDED values