Re: Propagate XLogFindNextRecord error to callers - Mailing list pgsql-hackers

On Mon, Mar 23, 2026 at 5:15 PM Anthonin Bonnefoy
<anthonin.bonnefoy@datadoghq.com> wrote:
> > +# Wrong WAL version. We copy an existing wal file and set the
> > +# page's magic value to 0000.
> >
> > Would it be better to describe the purpose of this test at the top?
> > For example:
> >
> >     # Test that pg_waldump reports a detailed error message when dumping
> >     # a WAL file with an invalid magic number (0000).
> >     {
> >             # The broken WAL file is created by copying a valid WAL file and
> >             # overwriting its magic number with 0000.
> >             my $broken_wal_dir = PostgreSQL::Test::Utils::tempdir_short();
>
> Sounds good, I've updated the patch.

Thanks for updating the patch!

It looks like the first part of the comment above wasn't included,
so I've added it. I also made a few cosmetic changes and updated
the commit message. Attached is the updated version of the patch.

Unless there are objections, I'll commit this version.

Regards,

--
Fujii Masao