Request a Demo
Home   >   mailing lists

Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion? - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?
Date
Msg-id CAHGQGwGprr+1ycMFpkni4fOM=CGt7iO1yGnJROHqU59sewV0-Q@mail.gmail.com
Whole thread
In response to Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?
List pgsql-hackers
Tree view 
On Tue, Apr 7, 2026 at 12:48 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> I agree with this line of reasoning here or in general as well but
> personally I am a bit hesitant to back patch changes which are not
> mandatory. In this particular case, I don't see any problem with
> backpatching the part of code you want to backpatch, so I leave it to
> your judgement.

Thanks for the comment!

I decided to backpatch commit 1362bc33e02. Although pg_sync_replication_slots()
lacks retry logic in v17 and v18 and is therefore less likely to block
promotion, the issue still exists in those versions.

Given that, it seemed worthwhile to backpatch the change and fix cases where
both the slotsync worker and pg_sync_replication_slots() can block promotion
when stuck in a wait.

I've pushed and backpatched the patch. Thanks!

Regards,

--
Fujii Masao

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier
Next
From: Chao Li
Date:
Subject: Re: doc: Improve wal_level and effective_wal_level GUC around logical replication