Re: pgbench: make verbose error messages thread-safe - Mailing list pgsql-hackers

On Fri, Apr 24, 2026 at 6:06 PM Chao Li <li.evan.chao@gmail.com> wrote:
> I am not too worried about that, because this code path is only used with --verbose-errors and only when printing
errormessages. In that situation, the cost of one extra memory allocation per log line should be much smaller than the
I/Ocost of writing the log message itself. So I think the simpler fix is probably acceptable. 

Yes, I feel the same way.


> But if we really care about the performance problem, I think PQExpBuffer might be better stored in TState that is per
thread,while CState is per connection. 

Agreed.

Regards,

--
Fujii Masao