Re: Improve tab completion for REFRESH MATERIALIZED VIEW - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Improve tab completion for REFRESH MATERIALIZED VIEW
Date
Msg-id CAHGQGwGjBQ0jaPVivFEfT-jh3HEU9VvjAX+1REh4Jy+wPDGcsw@mail.gmail.com
Whole thread Raw
In response to Re: Improve tab completion for REFRESH MATERIALIZED VIEW  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Improve tab completion for REFRESH MATERIALIZED VIEW
List pgsql-hackers
On Tue, Jan 26, 2016 at 10:25 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Tue, Jan 26, 2016 at 9:52 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>> Tab completion for REFRESH command is oddly with following scenario.
>>
>> =# REFRESH MATERIALIZED VIEW CONCURRENTLY hoge_mv [Tab]
>>
>> It shows only WITH DATA option without WITH NO DATA option.
>> Attached patch improves tab completion for WITH DATA/NO DATA option of
>> REFRESH MATERIALIZED VIEW.
>
> Correct. Nice catch and good patch.

The patch looks good to me.

While testing the patch, I found that
REFRESH MATERIALIZED VIEW <tab> doesn't list the materialized views.
I added the following change to the patch to fix that problem. Patch attached.

-       {"MATERIALIZED VIEW", NULL, NULL},
+       {"MATERIALIZED VIEW", NULL, &Query_for_list_of_matviews},

Regards,

--
Fujii Masao

Attachment

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: pg_lsn cast to/from int8
Next
From: Fujii Masao
Date:
Subject: Re: Improve tab completion for REFRESH MATERIALIZED VIEW