Re: doc: Improve description of io_combine_limit and io_max_combine_limit GUCs - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: doc: Improve description of io_combine_limit and io_max_combine_limit GUCs
Date
Msg-id CAHGQGwGfPzcin-_6XwPgVbWTOUFVZgHF5g9ROrwLUdCTfjy=0A@mail.gmail.com
Whole thread Raw
In response to Re: doc: Improve description of io_combine_limit and io_max_combine_limit GUCs  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
On Mon, Oct 13, 2025 at 10:33 PM Chao Li <li.evan.chao@gmail.com> wrote:
>
>
>
> On Oct 13, 2025, at 19:33, Karina Litskevich <litskevichkarina@gmail.com> wrote:
>
> On Thu, Oct 9, 2025 at 6:05 AM Chao Li <li.evan.chao@gmail.com> wrote:
>
>
> So, this patch looks good to me. Please any committer takes care of this patch.
>
>
> Thank you for the review!
>
> Could you please change the status of the commitfest entry [1] to
> Ready for Commiter if you believe it's ready?
>
> [1] https://commitfest.postgresql.org/patch/6115/
>
>
> Done.

The patch looks good to me.

I also noticed another issue in the io_max_combine_limit docs.
Since its context is PGC_POSTMASTER, shouldn't the following
description be updated to say "This parameter can only be set at server start"?

         This parameter can only be set in
         the <filename>postgresql.conf</filename> file or on the server
         command line.

Regards,

--
Fujii Masao



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Mark ItemPointer arguments as const thoughoutly
Next
From: Mats Kindahl
Date:
Subject: Re: Coccinelle for PostgreSQL development [1/N]: coccicheck.py