Re: Prevent setting NO INHERIT on partitioned not-null constraints - Mailing list pgsql-hackers

On Fri, May 22, 2026 at 6:22 AM Andreas Karlsson <andreas@proxel.se> wrote:
>
> On 5/21/26 5:01 PM, Jim Jones wrote:
> > The errcode is most likely wrong:
> >
> > ERRCODE_WRONG_OBJECT_TYPE -> ERRCODE_FEATURE_NOT_SUPPORTED
> >
> > At least it is inconsistent with an equivalent check in parse_utilcmd.c:
> >
> > if (cxt->ispartitioned && constraint->is_no_inherit)
> >    ereport(ERROR,
> >         errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> >            errmsg("not-null constraints on partitioned tables cannot be
> > NO INHERIT"));
>
> Thanks, that was a copy pasto. Version 2 is attached.

Thanks for the patch! It looks good to me.
Barring any objections, I will commit it.

This should be backpatched to v18, where ALTER TABLE ... ALTER
CONSTRAINT ... [NO] INHERIT
was added. Right?

Regards,

--
Fujii Masao