Request a Demo
Home   >   mailing lists

Re: Add missing stats_reset column to pg_statio_all_sequences view - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Add missing stats_reset column to pg_statio_all_sequences view
Date
Msg-id CAHGQGwGA5d0uigSj78xCyjPdc+j3V-qvxk=_NfbV6ScOrGQvbQ@mail.gmail.com
Whole thread Raw
In response to Re: Add missing stats_reset column to pg_statio_all_sequences view  (Sami Imseih <samimseih@gmail.com>)
Responses Re: Add missing stats_reset column to pg_statio_all_sequences view
List pgsql-hackers
Tree view 
On Fri, Mar 13, 2026 at 7:44 AM Sami Imseih <samimseih@gmail.com> wrote:
>
> After Creating this thread and the CF entry for it [1], I realized Shihao also
> created [2] yesterday. Sorry about that.
>
> We can stick with 6582 and Shihao can also get author credit.

Thanks to both Shihao and Sami for proposing patches!

Since the two patches are almost the same, I reviewed Sami's patch.
It looks good to me overall. One comment: for the tests added to stats.sql,
it would be better to verify that the stats of the specified sequence are
actually reset by using pg_stat_reset_single_table_counters().

Also, the documentation for pg_stat_reset_single_table_counters() should
mention that it can reset sequence statistics as well.

Regards,

--
Fujii Masao

pgsql-hackers by date:

Previous
From: Andrew Jackson
Date:
Subject: Re: Add Option To Check All Addresses For Matching target_session_attr
Next
From: Michael Paquier
Date:
Subject: Re: Streamify more code paths