Re: file_fdw: Support multi-line HEADER option. - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: file_fdw: Support multi-line HEADER option.
Date
Msg-id CAHGQGwG4E84NkTE-q4_LvWKs7C5p76gzzw5QQOuorEoBm=YJFQ@mail.gmail.com
Whole thread Raw
In response to Re: file_fdw: Support multi-line HEADER option.  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
On Tue, Jan 20, 2026 at 2:54 PM Chao Li <li.evan.chao@gmail.com> wrote:
> I am sorry maybe I didn’t express myself clear. But in v4, this problem is clearer:
>
> 1 - 0001
> ```
>         /*
> -        * Allow 0, 1, "true", "false", "on", "off", a non-negative integer, or
> -        * "match".
> +        * Allow 0, 1, "true", "false", "on", "off", an integer greater than or
> +        * equal to zero, or "match".
>          */
> ```
>
> Here, “0, 1” is a duplicate of “an integer greater than or equal to zero”, so the commend can be simplified as:

Yeah, the latest patch I attached upthread updates this comment and
removes "0, 1" from it.

Regards,

--
Fujii Masao



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: file_fdw: Support multi-line HEADER option.
Next
From: Bertrand Drouvot
Date:
Subject: Re: Remove redundant AssertVariableIsOfType uses in pg_upgrade