Re: remove WaitEventCustomCounterData - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: remove WaitEventCustomCounterData
Date
Msg-id CAHGQGwFojD_ibHvvHoYnQzomQvac2CvfS1hOHr+y46pNq6ZGFg@mail.gmail.com
Whole thread
In response to Re: remove WaitEventCustomCounterData  (Michael Paquier <michael@paquier.xyz>)
Responses Re: remove WaitEventCustomCounterData
List pgsql-hackers
On Thu, Jul 9, 2026 at 1:04 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Jul 08, 2026 at 09:50:33PM -0500, Nathan Bossart wrote:
> > While trying to understand the extent of our spinlock usage, I noticed that
> > WaitEventCustomCounterData->mutex is unnecessary because the counter is
> > only ever accessed with WaitEventCustomLock held exclusively.  So, here's a
> > patch to simplify matters a bit.  Thoughts?
>
> Indeed.  This removal sounds good to me, thanks.

#include "storage/spin.h" seems no longer needed in wait_event.c,
since the patch removes the last use of the spinlock code there.
So we can remove that include as well?

Regards,

--
Fujii Masao



pgsql-hackers by date:

Previous
From: Bertrand Drouvot
Date:
Subject: Re: Add per-backend AIO statistics
Next
From: Bertrand Drouvot
Date:
Subject: Re: BF mamba failure