Re: DOC: fixes multiple errors in alter table doc - Mailing list pgsql-hackers

On Tue, Mar 3, 2026 at 5:05 PM Chao Li <li.evan.chao@gmail.com> wrote:
> PFA v5:
>
> * In 0002, renamed c12 to c11 in the ALTER FOREIGN TABLE tests.
> * In 0002, added one more test case: ALTER FOREIGN TABLE ft1 DROP IF EXISTS no_column;

Thanks for updating the patches!

I've committed the 0001 patch and backpatched it to all supported versions.


 -- alter noexisting table
 ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 ADD COLUMN c4 integer;
+ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 ADD c5 integer;
<snip>
 ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 DROP COLUMN IF EXISTS no_column;
+ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 DROP IF EXISTS no_column;

Regarding 0002 patch, could you explain the reason for adding these
two additional tests? I was just curious why because other four tests that
the patch adds seem sufficient.

Aside from that point, the patch looks good to me.

Regards,

--
Fujii Masao