Request a Demo
Home   >   mailing lists

Re: Don't treat virtual generated columns as missing statistics in vacuumdb --missing-stats-only - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Don't treat virtual generated columns as missing statistics in vacuumdb --missing-stats-only
Date
Msg-id CAHGQGwFcQT-6QZYFJLXxZ0s+1cOZve3+QcTubrn3+=Qn4zFKUg@mail.gmail.com
Whole thread Raw
In response to Don't treat virtual generated columns as missing statistics in vacuumdb --missing-stats-only  (Yugo Nagata <nagata@sraoss.co.jp>)
Responses Re: Don't treat virtual generated columns as missing statistics in vacuumdb --missing-stats-only
List pgsql-hackers
Tree view 
On Wed, Aug 20, 2025 at 10:42 AM Yugo Nagata <nagata@sraoss.co.jp> wrote:
>
> Hi,
>
> I found that "vacuumdb --missing-stats-only" always performs ANALYZE
> on tables with a virtual generated column, since such columns currently
> never have statistics. This seems like an obvious waste, so I've attached
> a patch to fix it, ensuring that virtual generated columns are not
> regarded as missing statistics.

Thanks for the report and patch! This seems to be an oversight from
the commit that added virtual generated columns.

For the patch, shouldn't we also add a regression test for --missing-stats-only
with generated columns, to prevent this issue from happening again?

Regards,

--
Fujii Masao

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: VM corruption on standby
Next
From: Amit Kapila
Date:
Subject: Re: Logical Replication of sequences