Re: Is abort() still needed in WalSndShutdown()? - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Is abort() still needed in WalSndShutdown()?
Date
Msg-id CAHGQGwFaOJ_obx-XjwLmZW2sF7a9RqeOO4jxkKpG18GaFoiu=Q@mail.gmail.com
Whole thread Raw
In response to Re: Is abort() still needed in WalSndShutdown()?  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
On Mon, Jan 26, 2026 at 9:33 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> Yeah. Nowadays pg_noreturn is understood by all supported compilers.
> There are no guarantees on what the compiler will do with the
> information, but I would expect it to silence that warning on any
> half-decent compiler. (But as discussed, this is moot anyway because the
> returns 'void')
>
> > I'm thinking to remove the abort() call from WalSndShutdown() in the
> > attached patch.
>
> +1

Thanks for the check! I've pushed the patch.

Regards,

--
Fujii Masao



pgsql-hackers by date:

Previous
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Fix logical decoding not track transaction during SNAPBUILD_BUILDING_SNAPSHOT
Next
From: Amit Langote
Date:
Subject: Re: Batching in executor