Request a Demo
Home   >   mailing lists

Re: [PATCH] Release replication slot on error in SQL-callable slot functions - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: [PATCH] Release replication slot on error in SQL-callable slot functions
Date
Msg-id CAHGQGwFCLWw7nVYoR+9Z6DtzYNnDXv6YHseNRjaCXmdQsKnoWg@mail.gmail.com
Whole thread
In response to Re: [PATCH] Release replication slot on error in SQL-callable slot functions  (SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>)
Responses Re: [PATCH] Release replication slot on error in SQL-callable slot functions
List pgsql-hackers
Tree view 
On Thu, May 28, 2026 at 10:11 AM SATYANARAYANA NARLAPURAM
<satyanarlapuram@gmail.com> wrote:
> Thanks for the patches, I combined these changes in my latest patch. Please find the v5.

Thanks for updating the patch! But, v5 patch caused a compilation failure.

slotfuncs.c:119:32: error: too few arguments to function call, single
argument 'try_disable' was not specified
  119 |                         ReplicationSlotDropAcquired();
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../../src/include/replication/slot.h:338:13: note:
'ReplicationSlotDropAcquired' declared here
  338 | extern void ReplicationSlotDropAcquired(bool try_disable);
      |             ^                           ~~~~~~~~~~~~~~~~
slotfuncs.c:207:32: error: too few arguments to function call, single
argument 'try_disable' was not specified
  207 |                         ReplicationSlotDropAcquired();
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../../src/include/replication/slot.h:338:13: note:
'ReplicationSlotDropAcquired' declared here
  338 | extern void ReplicationSlotDropAcquired(bool try_disable);
      |             ^                           ~~~~~~~~~~~~~~~~
slotfuncs.c:922:32: error: too few arguments to function call, single
argument 'try_disable' was not specified
  922 |                         ReplicationSlotDropAcquired();
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../../src/include/replication/slot.h:338:13: note:
'ReplicationSlotDropAcquired' declared here
  338 | extern void ReplicationSlotDropAcquired(bool try_disable);
      |             ^                           ~~~~~~~~~~~~~~~~
3 errors generated.

Regards,

--
Fujii Masao

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Fix race during concurrent logical decoding activation
Next
From: Chengpeng Yan
Date:
Subject: Re: [PATCH] Fix overflow and underflow in regr_r2()