Re: vacuumdb --missing-stats-only and permission issue - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: vacuumdb --missing-stats-only and permission issue
Date
Msg-id CAHGQGwF78UFci8POW4x_Obx-67=9pRQ_fYdbq1yPdJfhpNO=Rg@mail.gmail.com
Whole thread Raw
In response to Re: vacuumdb --missing-stats-only and permission issue  (Corey Huinker <corey.huinker@gmail.com>)
Responses Re: vacuumdb --missing-stats-only and permission issue
List pgsql-hackers
On Sat, Aug 23, 2025 at 8:15 AM Corey Huinker <corey.huinker@gmail.com> wrote:
>
> On Fri, Aug 22, 2025 at 3:34 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>>
>> On Fri, Aug 22, 2025 at 09:01:36AM -0500, Nathan Bossart wrote:
>> > We'll also need documentation and test updates, of course.
>>
>> Here is an attempt at the docs/tests.  I also fixed a couple of small
>> issues in the query.
>>
>> --
>> nathan
>
>
> Good catch on the query change. I like the docs change.
>
> Tests look pretty straightforward. Was expecting one of them to test on a WARNING or not, but that might not be
reliableenough to capture. 
>
> +1

Thanks for working on this!

I tested by creating many tables with make installcheck and running
vacuumdb --missing-stats-only on the regression database.
Without the patch, the query to find tables to analyze took about 60 ms,
but with the patch it took 18 seconds. That seems too slow,
so probably we'll need to tune the query?

Regards,

--
Fujii Masao



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: make -C src/test/isolation failure in index-killtuples due to btree_gist
Next
From: Nathan Bossart
Date:
Subject: Re: vacuumdb --missing-stats-only and permission issue