Re: file_fdw: Support multi-line HEADER option. - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: file_fdw: Support multi-line HEADER option.
Date
Msg-id CAHGQGwF5Y02nN1iXwigi95ZKhviTpKLHVdT0j2EXZqV9Hj=jQw@mail.gmail.com
Whole thread Raw
In response to file_fdw: Support multi-line HEADER option.  (Shinya Kato <shinya11.kato@gmail.com>)
Responses Re: file_fdw: Support multi-line HEADER option.
Re: file_fdw: Support multi-line HEADER option.
List pgsql-hackers
On Fri, Jan 9, 2026 at 5:15 PM Shinya Kato <shinya11.kato@gmail.com> wrote:
>
> Hi hackers,
> (CC: Fujii-san, committer of bc2f348e8)
>
> Commit bc2f348e8[0] introduced multi-line HEADER support for COPY.
> However, file_fdw does not yet support it, so I have implemented it in
> the attached patch.
>
> Since foreign table options in CREATE/ALTER FOREIGN TABLE are
> specified as single-quoted strings, I updated defGetCopyHeaderOption()
> to handle string values as well.
>
> Thoughts?

+1

Could you add this patch to the next Commitfest? It would be better to
commit it in v19 so that multi-line header support is delivered for
both COPY and file_fdw at the same time.

Regards,

--
Fujii Masao



pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Fwd: pg18 bug? SELECT query doesn't work
Next
From: Jakub Wartak
Date:
Subject: Re: 64-bit wait_event and introduction of 32-bit wait_event_arg