Postgres Pro
Downloads
Home   >   mailing lists

Re: [bug fix] pg_rewind creates corrupt WAL files, and the standbycannot catch up the primary - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: [bug fix] pg_rewind creates corrupt WAL files, and the standbycannot catch up the primary
Date
Msg-id CAHGQGwF+Fk0Oa-Qv37uT7YJMKGM1WLELvc4GN9Z4vHBvdZ=Prw@mail.gmail.com
Whole thread Raw
In response to Re: [bug fix] pg_rewind creates corrupt WAL files, and the standbycannot catch up the primary  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [bug fix] pg_rewind creates corrupt WAL files, and the standbycannot catch up the primary  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On Sun, Mar 11, 2018 at 11:04 PM, Michael Paquier <michael@paquier.xyz> wrote:
> On Fri, Mar 09, 2018 at 08:22:49AM +0000, Tsunakawa, Takayuki wrote:
>> Thanks for reviewing.  All done.
>
> Thanks.  Please be careful with the indentation of the patch.  Attached
> is a slightly-updated version with a small modification in
> remove_target_file to make the code cleaner, a proposal of commit
> message and pgindent applied on the code.  I am switching that as ready
> for committer.

The patch looks good to me! Barring objection, I will commit it
and back-patch to 9.5 where pg_rewind was added.

Regards,

-- 
Fujii Masao

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Using base backup exclusion filters to reduce data transferredwith pg_rewind
Next
From: David Steele
Date:
Subject: Re: PATCH: Configurable file mode mask