Request a Demo
Home   >   mailing lists

Re: [PATCH] Release replication slot on error in SQL-callable slot functions - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: [PATCH] Release replication slot on error in SQL-callable slot functions
Date
Msg-id CAHGQGwEbt2UdAsA4i8aE0snysmEtG0YeRtpr-NO=uTtJa4AB-Q@mail.gmail.com
Whole thread
In response to Re: [PATCH] Release replication slot on error in SQL-callable slot functions  (shveta malik <shveta.malik@gmail.com>)
Responses Re: [PATCH] Release replication slot on error in SQL-callable slot functions
List pgsql-hackers
Tree view 
On Wed, May 27, 2026 at 8:00 PM shveta malik <shveta.malik@gmail.com> wrote:
> pg_copy_physical_replication_slot() should not have it as the common
> 'copy_replication_slot' is already fixed in the patch.

copy_replication_slot() calls create_physical_replication_slot() before
entering the PG_TRY/PG_CATCH block. So if create_physical_replication_slot()
throws an error, wouldn't the same issue still occur?

>  I will review
> the others.

Thanks!

Regards,

--
Fujii Masao

pgsql-hackers by date:

Previous
From: Thom Brown
Date:
Subject: Re: generic plans and "initial" pruning
Next
From: Robert Haas
Date:
Subject: Re: Pgbench: remove synchronous prepare