Re: Re: pg_test_timing: fix unit typo and widen diff type - Mailing list pgsql-hackers

On Thu, Apr 9, 2026 at 3:13 PM wang.xiao.peng <wxp_728@163.com> wrote:
> Just finished reviewing the v3 patches - looks good to me. The pg_leftmost_one_pos64 fix is spot on, and using
INT64_FORMATfor the error message is the right approach. 

Since pg_leftmost_one_pos64() can return up to 63, should the size of
histogram[] be changed from 32 to 64? If we want to display the full
histogram[] in the output, max_bit in output() would also need to be set to 63.
Alternatively, it may be fine to keep max_bit = 31 and show only
the first 32 histogram entries.

Patch 0001 looks good to me.

Regards,

--
Fujii Masao