Re: pg_stat directory and pg_stat_statements - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: pg_stat directory and pg_stat_statements
Date
Msg-id CAHGQGwEH1p2jj4kG33xm0qH0LwLyp7=Dn6A5WvQzv3HGuTbbLQ@mail.gmail.com
Whole thread Raw
In response to Re: pg_stat directory and pg_stat_statements  (Peter Geoghegan <pg@heroku.com>)
Responses Re: pg_stat directory and pg_stat_statements  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
On Thu, May 29, 2014 at 3:02 PM, Peter Geoghegan <pg@heroku.com> wrote:
> On Wed, May 28, 2014 at 10:49 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> You're concerned about the scenario using pg_upgrade? I'm not sure the detail
>> of pg_upgrade. But if it doesn't work properly, we should have gotten
>> the trouble
>
> I'm not worried about pg_upgrade, because by design pg_stat_statements
> will discard stats files that originated in earlier versions. However,
> I don't see a need to change pg_stat_statements to serialize its
> statistics to disk in the pg_stat directory before we branch off 9.4.
> As you mentioned, it's harmless.

Yeah, that's an idea. OTOH, there is no *strong* reason to postpone
the fix to 9.5. So I just feel inclined to apply the fix now...

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Re-create dependent views on ALTER TABLE ALTER COLUMN ... TYPE?
Next
From: Robert Haas
Date:
Subject: Re: Jsonb: jbvBinary usage in the convertJsonbValue?