Re: Reset waitStart when a lock wait fails - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Reset waitStart when a lock wait fails
Date
Msg-id CAHGQGwEAno940FOJ3kW=ys3KQ94y7GQ2fBNz6i+Wvv09ZsDnhw@mail.gmail.com
Whole thread
In response to Re: Reset waitStart when a lock wait fails  (shihao zhong <zhong950419@gmail.com>)
Responses Re: Reset waitStart when a lock wait fails
List pgsql-hackers
On Mon, Sep 28, 2026 at 12:51 AM shihao zhong <zhong950419@gmail.com> wrote:
>
> Hi Andrew,
>
> > 1) I think 0001 is not needed anymore once 0002 is applied. With
> > 0002, the waiting backend always clears waitStart itself when the wait
> > ends at the end of ProcSleep(), or in LockErrorCleanup().
> > RemoveFromWaitQueue() is only called from CheckDeadLock() and
> > LockErrorCleanup(), and both paths reach one of these new resets.
> >
> > Maybe it is simpler to merge 0001 and 0002 into one commit?
> > They fix the same problem and would be backpatched together.
>
> Agreed, v3 merges them into one patch. The code is the same as v2.

Thanks for updating the patch! I made only cosmetic changes and pushed it.

Regards,

--
Fujii Masao



pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Bug in logical decoding with DDL and subtransactions
Next
From: shihao zhong
Date:
Subject: Re: Reset waitStart when a lock wait fails